mirror of
https://github.com/motajs/template.git
synced 2026-09-24 18:50:24 +08:00
docs(07): final verification refresh covering security/validation/uat artifacts
This commit is contained in:
parent
393e4cc7a8
commit
2d718755c2
@ -1,6 +1,6 @@
|
||||
---
|
||||
phase: 07-data-fixes
|
||||
verified: 2026-09-16T05:49:24Z
|
||||
verified: 2026-09-16T06:04:11Z
|
||||
status: passed
|
||||
score: 15/15 must-haves verified
|
||||
covered_files:
|
||||
@ -25,6 +25,8 @@ covered_files:
|
||||
- .planning/phases/07-data-fixes/07-08-SUMMARY.md
|
||||
- .planning/phases/07-data-fixes/07-CONTEXT.md
|
||||
- .planning/phases/07-data-fixes/07-REVIEW.md
|
||||
- .planning/phases/07-data-fixes/07-SECURITY.md
|
||||
- .planning/phases/07-data-fixes/07-UAT.md
|
||||
- .planning/phases/07-data-fixes/07-VALIDATION.md
|
||||
- packages-user/data-base/src/enemy/manager.test.ts
|
||||
- packages-user/data-base/src/enemy/manager.ts
|
||||
@ -54,7 +56,7 @@ covered_files:
|
||||
- packages-user/data-system/src/combat/damage.ts
|
||||
- packages-user/data-system/src/combat/mapDamage.test.ts
|
||||
- packages-user/data-system/src/combat/mapDamage.ts
|
||||
covered_digest: "v1:sha256:3bf6ed091cc87e9e495a7fea8e47719280754fca71eb0a29f4f2d5e2f401996e"
|
||||
covered_digest: "v1:sha256:2bb44f7dcc29a0af776ad9c1a6bf1f99aeed25a8b7227b3b769232fea11c8bc1"
|
||||
behavior_unverified: 0
|
||||
overrides_applied: 0
|
||||
re_verification:
|
||||
@ -94,7 +96,7 @@ advisory:
|
||||
evidence_status: "none provided"
|
||||
- finding: "WR-06 — HeroEquipment.loadState() appends spurious Equip replay commands because it restores through the recording public equip()"
|
||||
category: other
|
||||
reason: "Pre-existing loadState() body (equipment.ts diff is confined to getCouldEquipSlot :141 and saveState :331-332). The review notes the effect is masked by saveable iteration order in CoreState.loadState(). No must-have covers replay-route cleanliness during load; no test fails on it."
|
||||
reason: "Pre-existing loadState() body (equipment.ts diff is confined to getCouldEquipSlot and saveState). The review notes the effect is masked by saveable iteration order in CoreState.loadState(). No must-have covers replay-route cleanliness during load; no test fails on it."
|
||||
evidence_status: "none provided"
|
||||
- finding: "WR-07 — ReplayArray.insert()/delete()/set() do not validate index bounds"
|
||||
category: other
|
||||
@ -105,21 +107,24 @@ advisory:
|
||||
# Phase 7: 数据端缺陷修复 Verification Report
|
||||
|
||||
**Phase Goal:** 修复 Phase 6 单元测试暴露的数据端疑似缺陷，使正确预期用例转绿，且仅限数据端、不涉及渲染端
|
||||
**Verified:** 2026-09-16T05:49:24Z
|
||||
**Verified:** 2026-09-16T06:04:11Z
|
||||
**Status:** passed
|
||||
**Re-verification:** Yes — after post-verification commits (0224c2e doc-only `replay/types.ts` param-table fix; 4f31627 untrack/ignore the dispatch sentinel; 9e91785 add `07-REVIEW.md`; plus `state.json`/`milestone.lock` tracking churn)
|
||||
**Re-verification:** Yes — fingerprint refresh over the CURRENT artifact set (SECURITY.md + validated VALIDATION.md + UAT.md landed after the prior `verified:` timestamp). This is the final verification write; all phase artifacts now exist and are committed.
|
||||
|
||||
**Method note:** every PLAN `must_haves` block (all 8 plans), all 4 ROADMAP Success Criteria, and the 20 `06-TEST-FINDINGS.md` entries were re-derived from the codebase. SUMMARY.md claims were treated as unverified hypotheses and falsified or confirmed against source diffs, source files, and a fresh `pnpm test:ci` run. The stale previous fingerprint was replaced (covered set now includes the post-verification `replay/types.ts` change and the `07-REVIEW.md` artifact).
|
||||
**Method note:** every PLAN `must_haves` block (all 8 plans), all 4 ROADMAP Success Criteria, and the 20 `06-TEST-FINDINGS.md` entries were re-derived from the codebase in this run. SUMMARY.md claims were treated as unverified hypotheses and falsified or confirmed against source diffs, source files, and a fresh `pnpm test:ci` run. Every one of the 15 truths was re-checked against the current source; no truth was carried forward on the prior report's word alone.
|
||||
|
||||
### Post-verification changes reconciled (delta vs prior report)
|
||||
|
||||
| Prior finding | Disposition now | Evidence |
|
||||
| --- | --- | --- |
|
||||
| ⚠️ W-01 stale replay param-type table in public jsdoc (`replay/types.ts`) | **RESOLVED** | Commit `0224c2e`. `types.ts:249-258` and `:336-347` now publish the post-renumbering table. Both byte-size columns were checked against the implementation and are correct (int64/float 9 Byte; bigint n+2 at `array.ts:284`; long string n+5 at `:300`; short string n+1 at `:293`). Residual cosmetic nit: `:341` labels type 4 `int64` and `:344` type 7 `bigint` where the sibling table says `非负 int64`/`非负 bigint` — byte sizes and renumbering are accurate, so this is ℹ️ Info only. |
|
||||
| ℹ️ I-02 `.gsd/dispatch-isolation-sentinel.json` committed & un-gitignored | **RESOLVED** | Commit `4f31627`: file untracked, `.gitignore` now contains `.gsd/` (`git diff 615ff5f..HEAD -- .gitignore`). |
|
||||
| ℹ️ I-03 `REQUIREMENTS.md` showed `FIX-01 … Pending`, `ROADMAP.md` showed Phase 7 `In Progress` | **RESOLVED** | `REQUIREMENTS.md:41` is `[x] FIX-01`, traceability row `:70` = `Complete`; `ROADMAP.md:327` = `7. … | 8/8 | Complete | 2026-09-16`. |
|
||||
| ℹ️ I-04 Phase 7 Wave 8 checkbox `[ ]` | **RESOLVED** | `ROADMAP.md:312` is `[x]`. |
|
||||
| — | **NEW** code review (`07-REVIEW.md`, 2 critical + 7 warnings) | All 9 findings classified **advisory** (see `advisory:` frontmatter and the Advisory section). None contradicts a must-have; CR-01 is explicitly registered as 只登记不修; neither critical touches a file modified since the prior verification. |
|
||||
| ⚠️ W-01 stale replay param-type table in public jsdoc (`replay/types.ts`) | **RESOLVED** | Commit `0224c2e` (carried). `types.ts:249-258` and `:336-347` publish the post-renumbering table; both byte-size columns re-checked against the implementation this run — int64/float 9 Byte; bigint n+2 (`array.ts:284`); long string n+5 (`:300`); short string n+1 (`:293`). Residual cosmetic nit: `:341` labels type 4 `int64` / `:344` type 7 `bigint` where the sibling table says `非负 int64`/`非负 bigint` — byte sizes and renumbering accurate, ℹ️ Info only. |
|
||||
| ℹ️ I-02 `.gsd/dispatch-isolation-sentinel.json` committed & un-gitignored | **RESOLVED** | Commit `4f31627` (carried): file untracked, `.gitignore` contains `.gsd/`. |
|
||||
| ℹ️ I-03 `REQUIREMENTS.md` showed `FIX-01 … Pending`, `ROADMAP.md` showed Phase 7 `In Progress` | **RESOLVED** | Re-checked this run: `REQUIREMENTS.md:41` = `[x] FIX-01`, traceability row `:70` = `Complete`; `ROADMAP.md:327` = `7. … \| 8/8 \| Complete \| 2026-09-16`. |
|
||||
| ℹ️ I-04 Phase 7 Wave 8 checkbox `[ ]` | **RESOLVED** | Re-checked this run: `ROADMAP.md:312` = `[x]`. |
|
||||
| — | **NEW** `07-UAT.md` (commit `d6fcd1c`) | `status: complete`; total 6 / passed 6 / issues 0. The 4 automated items map to active passing tests; the 2 by-design retained items (`#06-05-3`, floor-switch re-injection) match D-06/D-07. |
|
||||
| — | **NEW** `07-SECURITY.md` (commit `d49f36d`) | `status: verified`, `threats_open: 0`, 14/14 threats closed (13 mitigate + 1 accept `T-7-14`; plus `T-7-SC` accepted). AR-07-01/AR-07-02 recorded. Reviewed this run: each `mitigate` row matches a phase-7 code change (T-7-01…T-7-13). |
|
||||
| — | **NEW** `07-VALIDATION.md` became `validated` (commit `393e4cc`) | `status: validated`, `nyquist_compliant: true`, `wave_0_complete: true`. Per-finding map covers all 20 findings; full-suite command `pnpm test:ci` re-executed green this run. This is the artifact whose post-`verified:` change made the prior fingerprint stale. |
|
||||
| — | **CARRIED** code review (`07-REVIEW.md`, 2 critical + 7 warnings + 5 info) | All 9 CR/WR findings remain classified **advisory** (see `advisory:` frontmatter). `07-REVIEW.md` is unchanged since the prior verification. None contradicts a must-have; CR-01 is explicitly registered as 只登记不修; neither critical touches a file modified since the prior verification. |
|
||||
|
||||
## Goal Achievement
|
||||
|
||||
@ -128,23 +133,23 @@ advisory:
|
||||
| # | Truth | Status | Evidence |
|
||||
| --- | --- | --- | --- |
|
||||
| 1 | **SC1** — 登记的数据端疑似缺陷全部处置完毕（修复或经用户裁定改契约/不修复）：`#06-01-1..4`、`#06-03-1`、`#06-04-1..4`、`#06-05-1..3`、`#06-06-1`、`#06-07-1`、`#06-08-1`、`#06-09-1/2/3/5`、`#06-15-1` | ✓ VERIFIED | 19/20 fixed with production-code evidence (per-finding table below); `#06-05-3` retained by design (D-06); `#06-07-1` user wiring present in `core.ts:232-241`. `#06-09-4` correctly excluded (obsoleted by `c08f3f8`). |
|
||||
| 2 | **SC2** — 对应的正确预期 `it.skip` 用例在修复后取消 skip 并通过；无法修复的缺陷经用户确认后同步修正接口文档/契约 | ✓ VERIFIED | Repo-wide disabled-test census = **1** (`equipment.test.ts:306`, `#06-05-3`, D-06 retained + comment at `:305`). All 19 target skips are active and green. Contract alignment verified: `#06-01-3` impl → `types.ts:772` jsdoc (impl aligned to doc, unchanged); `#06-06-1` → `logger.json` warn-128 text; `#06-09-5` → warn-178 text; the stale `replay/types.ts` table is now fixed (W-01 resolved). |
|
||||
| 3 | **SC3** — `pnpm test:ci` 全绿且不新增跳过用例，数据范围 `check:type` / `check:circular` 门禁通过 | ✓ VERIFIED | Fresh run: `Test Files 66 passed (66)`, `Tests 680 passed | 1 skipped (681)`. `eslint` on all 28 changed data-side files = exit 0. `vue-tsc --noEmit` = 27 error lines, **0 in phase-7 changed files** (all in `client-modules`/`legacy-plugin-data`/`legacy-ui`, pre-existing). `check:circular` = 4 cycles, all in `packages/render`/`packages/anon-tokyo` (non-data). |
|
||||
| 4 | **SC4** — 改动仅限数据端（`packages` 与 `packages-user/data-*`），不改动渲染端 `@user/client-*` 与 legacy 渲染接线 | ✓ VERIFIED | `git diff --name-only 817201c..HEAD` filtered for `client|legacy|render` → **empty**. Non-planning changes are `.gitignore`, the removed `.gsd` sentinel, and 28 `packages-user/data-*` files. No `package.json` / `pnpm-lock.yaml` change. |
|
||||
| 5 | combat 四条根因（含同根因 `#06-15-1`）修复，4 个 `it.skip` 转绿 | ✓ VERIFIED | `damage.ts:229-234` (`targetInfo = middleInfo` inside the `right` branch); `context.ts:696-699` (all `enemyViewMap` views `reset()` before the full buildup, unconditional); `mapDamage.ts:266-285` `registerSourcedDamage` + `:412-425` skip deleted views; `combat.ts:179-180`. Tests un-skipped and green, incl. `mapDamage.test.ts:532` `removes enemy-sourced damage when the enemy is deleted`. |
|
||||
| 6 | combat `before` 返回 `false` 才放弃战斗（对齐 `types.ts:772` jsdoc）；3 条既有完整流程用例纠偏后仍绿 | ✓ VERIFIED | `combat.ts:179` `const proceed = await script.before(...)` / `:180` `if (!proceed) return damage;`. `types.ts` jsdoc already said 返回 `false`…放弃战斗 and is unchanged (implementation aligned to doc, D-03). 3 existing cases updated; the corrected assertion is stronger (4-element call order), not weaker. |
|
||||
| 7 | 07-01 不新增任何 `it.skip` | ✓ VERIFIED | Diff shows only `-it.skip(` → `+it(` transitions in the combat test files; repo-wide census remains 1. |
|
||||
| 8 | enemy 创建入口接入复用映射；未注册复用映射的 code/id 仍返回模板克隆 | ✓ VERIFIED | `manager.ts:120` `createEnemy` and `:128` `createEnemyById` use `internalGetPrefab`; invariant comment at `:125-126`; 2 skips un-skipped, green. |
|
||||
| 9 | replay 编解码精确往返（int64 乘数、多字节 bigint、负值 type 5/8）＋ `delete`/`insert` 索引位移正确＋类型码表整体重编号 | ✓ VERIFIED | `array.ts:647` decode `low + high * 2147483648` (was `2147483647`); `:653` type-5 negation; `:269-285` bigint magnitude bytes; `:660-666` type-8 `getUint8` read; `:377-394` write path; `:446-450` `insert` `copyWithin` direction reversed; `:467-495` `delete` uses new `getParamRange` + `for (let i = index; ...)`; `:677` `length = type - 9`. `array.test.ts` = 46 `it(` / 0 `it.skip(`. |
|
||||
| 10 | hero `#06-09-1`（高）/`#06-09-2`/`#06-05-1`/`#06-05-2` 修复，8 个 skip 转绿 | ✓ VERIFIED | `equipStore.ts:119` `state.value` (was `state.percentage`) in `loadNoCompression`; `:137-150` `loadDiff` seeds from `this.item.equip.value/percentage` then overlays diff; `equipment.ts:331-332` `saveState` deep copy (`new Map`, `[...slots]`); `:141` `empty === -1`; `attribute.ts:82-85` `finalAttribute[name] = this.attribute[name]` when no modifier. 8 skips un-skipped, green. |
|
||||
| 11 | 码 147 对应用例保留 `it.skip` 并带中文说明注释，生产代码一行未动 | ✓ VERIFIED | `equipment.test.ts:305-306`: comment 保留错误码 147…设计如此…生产代码不修改 immediately precedes the single `it.skip`. `equipment.ts` diff contains no 147-related change; `logger.json` warn-147 text unchanged. |
|
||||
| 12 | 越图 `transferToDynamic` 发码 128；`DynamicTile.loadState` 恢复 `num`；码 131 既有断言不回退 | ✓ VERIFIED | `mapLayer.ts:441` `logger.warn(128, x.toString(), y.toString())`. `dynamicTile.ts:122-123` `loadState` calls `this.set(save.num)`. `logger.json` warn-131 text unchanged. |
|
||||
| 13 | `backward(count>1)` 保持同轴、朝向不变；单步 `backward` 与 `forward(2)` 不回退；jsdoc 与实现一致 | ✓ VERIFIED | `mover.ts:501-505` backward basis is `this.faceDirection` (not `getCurrentDirection()`), so step 1's written opposite no longer becomes step 2's basis. 1 skip un-skipped, green. |
|
||||
| 14 | 码 178 = `loaded.difference(total)`；缺 key 只触发 177 不触发 178；既有非 skip 用例按 D-05 纠偏 | ✓ VERIFIED | `core.ts:540` `const remain = loaded.difference(total);` — matches `logger.json` warn-178 文案 (saved but not be loaded) and stays disjoint from warn-177 (needed but absent). `saveablesRoundTrip.test.ts` case flipped to `toContain(177)` + `not.toContain(178)`; original skip un-skipped and green. |
|
||||
| 15 | path `#06-07-1`：`core.ts` 提供 `useMapState`/`useMapLayer(null)`/`usePassPredicate`；测试侧绑定事件层后顶层录像瞬移转绿、用例重命名且不再 skip；AI 未修改生产源码；楼层切换重注入缺口登记为用户负责项 | ✓ VERIFIED | `core.ts:232-241` user wiring present (commit `1ff22dd`). `replayPlayback.test.ts:363` `it('plays a teleport step after the event layer is bound on floor activation', …)` — renamed, active, green. 07-08's commits (`123493c`,`4a25e2e`,`2f148c9`) touched only the PLAN and that test file. Residual gaps registered at `07-08-SUMMARY.md` coverage D2/D3 (`human_judgment: true`). |
|
||||
| 2 | **SC2** — 对应的正确预期 `it.skip` 用例在修复后取消 skip 并通过；无法修复的缺陷经用户确认后同步修正接口文档/契约 | ✓ VERIFIED | Repo-wide disabled-test census = **1** (`equipment.test.ts:306`, `#06-05-3`, D-06 retained + comment at `:305`). All 19 target skips re-confirmed active `it(` this run (named titles listed in Behavioral Spot-Checks). Contract alignment verified: `#06-01-3` impl → `types.ts:772` jsdoc (impl aligned to doc, unchanged); `#06-06-1` → `logger.json` warn-128 text; `#06-09-5` → warn-178 text; the stale `replay/types.ts` table is fixed (W-01 resolved). |
|
||||
| 3 | **SC3** — `pnpm test:ci` 全绿且不新增跳过用例，数据范围 `check:type` / `check:circular` 门禁通过 | ✓ VERIFIED | Fresh run: `Test Files 66 passed (66)`, `Tests 680 passed | 1 skipped (681)`. `eslint` on all 28 changed data-side files = exit 0. `vue-tsc --noEmit` = 27 error lines, **0 in phase-7 changed files** (all in `legacy-ui`/`client-modules`/`legacy-plugin-data`, pre-existing — the single `data-state` substring match is the module path inside a `legacy-ui` diagnostic). `check:circular` = 4 cycles, all in `packages/render`/`packages/anon-tokyo` (non-data); none references a phase-7 file. |
|
||||
| 4 | **SC4** — 改动仅限数据端（`packages` 与 `packages-user/data-*`），不改动渲染端 `@user/client-*` 与 legacy 渲染接线 | ✓ VERIFIED | `git diff --name-only 817201c..HEAD` filtered for `client\|legacy\|render` → **empty**. Non-planning changes are `.gitignore`, the removed `.gsd` sentinel, and 28 `packages-user/data-*` files. No `package.json` / `pnpm-lock.yaml` change. |
|
||||
| 5 | combat 四条根因（含同根因 `#06-15-1`）修复，4 个 `it.skip` 转绿 | ✓ VERIFIED | `damage.ts:230-231` (`targetInfo = middleInfo` inside the `right` branch); `context.ts:696-698` (all `enemyViewMap` views `reset()` before the full buildup, unconditional); `mapDamage.ts:267-285` `registerSourcedDamage` + `:411-425` skip deleted views; `combat.ts:179-180`. Tests active and green: `damage.test.ts:579`/`:677`, `mapDamage.test.ts:532`, `context.test.ts:625`. |
|
||||
| 6 | combat `before` 返回 `false` 才放弃战斗（对齐 `types.ts:772` jsdoc）；3 条既有完整流程用例纠偏后仍绿 | ✓ VERIFIED | `combat.ts:179` `const proceed = await script.before(...)` / `:180` `if (!proceed) return damage;`. `types.ts` jsdoc already said 返回 `false`…放弃战斗 and is unchanged (implementation aligned to doc, D-03). `combat.test.ts:488` active and green; the corrected assertion is stronger (4-element call order), not weaker. |
|
||||
| 7 | 07-01 不新增任何 `it.skip` | ✓ VERIFIED | Diff shows only `-it.skip(` → `+it(` transitions in the combat test files; repo-wide census remains 1 (the pre-existing D-06 skip). |
|
||||
| 8 | enemy 创建入口接入复用映射；未注册复用映射的 code/id 仍返回模板克隆 | ✓ VERIFIED | `manager.ts:119-121` `createEnemy` and `:127-131` `createEnemyById` use `internalGetPrefab`; invariant comment at `:124-125`; `internalGetPrefab` falls back to the raw code/id when unmapped (`:132-138`). `manager.test.ts:272` active and green. |
|
||||
| 9 | replay 编解码精确往返（int64 乘数、多字节 bigint、负值 type 5/8）＋ `delete`/`insert` 索引位移正确＋类型码表整体重编号 | ✓ VERIFIED | `array.ts:647` decode `low + high * 2147483648` (was `…3647`); `:653` type-5 negation; `:269-284` bigint magnitude bytes (`paramType: param < 0n ? 8 : 7`); `:660-666` type-8 `getUint8` read; `:377-395` write path (type 4/5 split, 7/8 length-prefixed); `:450` `insert` `copyWithin(paramStart + length, paramStart)` direction reversed; `:467-495` `delete` uses new `getParamRange` + `for (let i = index; …)`; `:677` `length = type - 9`. `array.test.ts` = 46 `it(` / 0 `it.skip(`; the 4 target titles active. |
|
||||
| 10 | hero `#06-09-1`（高）/`#06-09-2`/`#06-05-1`/`#06-05-2` 修复，8 个 skip 转绿 | ✓ VERIFIED | `equipStore.ts:118-122` `state.value` (was `state.percentage`) in `loadNoCompression`; `:136-152` `loadDiff` seeds from `this.item.equip.value/percentage` then overlays diff; `equipment.ts:331-332` `saveState` deep copy (`new Map`, `[...slots]`); `:141` `empty === -1` preferred-empty-slot logic. `attribute.ts:82-85` `finalAttribute[name] = this.attribute[name]` when no modifier. 8 skips un-skipped, green. |
|
||||
| 11 | 码 147 对应用例保留 `it.skip` 并带中文说明注释，生产代码一行未动 | ✓ VERIFIED | `equipment.test.ts:305-306`: comment 保留错误码 147…设计如此…生产代码不修改 immediately precedes the single `it.skip`. `git diff 817201c..HEAD -- equipment.ts` contains no `147` hunk; `logger.json` is unchanged by the phase (`git diff --name-only … -- packages/common/src/logger.json` empty). |
|
||||
| 12 | 越图 `transferToDynamic` 发码 128；`DynamicTile.loadState` 恢复 `num`；码 131 既有断言不回退 | ✓ VERIFIED | `mapLayer.ts:441` `logger.warn(128, x.toString(), y.toString())`. `dynamicTile.ts:122` `loadState` calls `this.set(save.num)` before restoring events. `logger.json` warn-131 text unchanged. `mapLayer.test.ts:418` and `map/saveLoad.test.ts:164` active and green. |
|
||||
| 13 | `backward(count>1)` 保持同轴、朝向不变；单步 `backward` 与 `forward(2)` 不回退；jsdoc 与实现一致 | ✓ VERIFIED | `mover.ts:501-505` backward basis is `this.faceDirection` (not `getCurrentDirection()`), so step 1's written opposite no longer becomes step 2's basis. jsdoc at `mover.ts:309-313` now states 每一步都以当前朝向为基准…同一轴线，朝向不变. `mover.test.ts:307` active and green. |
|
||||
| 14 | 码 178 = `loaded.difference(total)`；缺 key 只触发 177 不触发 178；既有非 skip 用例按 D-05 纠偏 | ✓ VERIFIED | `core.ts:540` `const remain = loaded.difference(total);` — matches `logger.json` warn-178 文案 (saved but not be loaded) and stays disjoint from warn-177 (needed but absent). `saveablesRoundTrip.test.ts:322-335` asserts `toContain(177)` + `not.toContain(178)`; `:339-350` asserts 178 for unloaded keys. Both active and green. |
|
||||
| 15 | path `#06-07-1`：`core.ts` 提供 `useMapState`/`useMapLayer(null)`/`usePassPredicate`；测试侧绑定事件层后顶层录像瞬移转绿、用例重命名且不再 skip；AI 未修改生产源码；楼层切换重注入缺口登记为用户负责项 | ✓ VERIFIED | `core.ts:236` `useMapState(this.maps)`, `:238` `useMapLayer(null)` (with 有意设计 comment), `:239-241` `usePassPredicate(new DefaultPassPredicateImpl(this.maps))` (commit `1ff22dd`). `replayPlayback.test.ts:363` `it('plays a teleport step after the event layer is bound on floor activation', …)` — renamed, active, green; `:365-367` binds `map.eventLayer`. 07-08's commits (`123493c`,`4a25e2e`,`2f148c9`) touched only the PLAN, the test, and docs. Residual gaps registered at `07-08-SUMMARY.md` coverage D2/D3 (`human_judgment: true`). |
|
||||
|
||||
**Score:** 15/15 truths verified (0 present-but-behavior-unverified)
|
||||
**behavior_unverified:** 0 — every truth that asserts runtime behaviour is backed by an active, passing test executed in `pnpm test:ci`.
|
||||
**behavior_unverified:** 0 — every truth that asserts runtime behaviour is backed by an active, passing test executed in this run's `pnpm test:ci`.
|
||||
|
||||
### Deferred Items
|
||||
|
||||
@ -170,20 +175,20 @@ New-scope findings from Step 7 with no deterministic evidence — reported, not
|
||||
|
||||
| Artifact | Expected | Status | Details |
|
||||
| --- | --- | --- | --- |
|
||||
| `packages-user/data-system/src/combat/damage.ts` | `findNextCritical` `info` aligned with yielded value | ✓ VERIFIED | `:229-234`; wired through `calculateCritical`; data flows from `calculator.calculate` |
|
||||
| `packages-user/data-system/src/combat/context.ts` | Full buildup resets all `EnemyView` | ✓ VERIFIED | `:696-699` unconditional loop over `enemyViewMap.values()` |
|
||||
| `packages-user/data-system/src/combat/mapDamage.ts` | Sourced-damage reverse index coherent across write/delete/refresh | ✓ VERIFIED | `:266-285`, `:318-324`, `:362-368`, `:412-425` |
|
||||
| `packages-user/data-system/src/combat/damage.ts` | `findNextCritical` `info` aligned with yielded value | ✓ VERIFIED | `:230-231`; wired through `calculateCritical`; data flows from `calculator.calculate` |
|
||||
| `packages-user/data-system/src/combat/context.ts` | Full buildup resets all `EnemyView` | ✓ VERIFIED | `:696-698` unconditional loop over `enemyViewMap.values()` |
|
||||
| `packages-user/data-system/src/combat/mapDamage.ts` | Sourced-damage reverse index coherent across write/delete/refresh | ✓ VERIFIED | `:267-285`, `:405-419`, `:411-425` |
|
||||
| `packages-user/data-system/src/combat/combat.ts` | `before` short-circuit per jsdoc | ✓ VERIFIED | `:179-180` |
|
||||
| `packages-user/data-base/src/enemy/manager.ts` | All code/id template lookups go through `internalGetPrefab` | ✓ VERIFIED | `:120`, `:128`; invariant comment `:125-126` |
|
||||
| `packages-user/data-common/src/replay/array.ts` | Exact encode/decode round-trip + correct index edit | ✓ VERIFIED | type table `:11-26`, normalize `:225-310`, write `:377-398`, insert/delete `:437-499`, decode `:640-681` |
|
||||
| `packages-user/data-common/src/replay/types.ts` | Public param-type table aligned with the renumbered codes | ✓ VERIFIED | `:249-258`, `:336-347`; byte sizes cross-checked against `array.ts` (W-01 resolved by `0224c2e`) |
|
||||
| `packages-user/data-base/src/hero/equipStore.ts` | NoCompression restores value/percentage; compressed loads fall back to `item.equip` | ✓ VERIFIED | `:119`, `:137-150` |
|
||||
| `packages-user/data-base/src/hero/equipment.ts` | `saveState` deep copy; prefer first empty slot | ✓ VERIFIED | `:331-332`, `:141` |
|
||||
| `packages-user/data-base/src/enemy/manager.ts` | All code/id template lookups go through `internalGetPrefab` | ✓ VERIFIED | `:119-131`; invariant comment `:124-125`; fallback `:132-138` |
|
||||
| `packages-user/data-common/src/replay/array.ts` | Exact encode/decode round-trip + correct index edit | ✓ VERIFIED | type table `:11-25`, normalize `:266-300`, write `:377-395`, insert/delete `:437-500`, decode `:640-681` |
|
||||
| `packages-user/data-common/src/replay/types.ts` | Public param-type table aligned with the renumbered codes | ✓ VERIFIED | `:249-258`, `:336-347`; byte sizes cross-checked against `array.ts` this run |
|
||||
| `packages-user/data-base/src/hero/equipStore.ts` | NoCompression restores value/percentage; compressed loads fall back to `item.equip` | ✓ VERIFIED | `:118-122`, `:136-152` |
|
||||
| `packages-user/data-base/src/hero/equipment.ts` | `saveState` deep copy; prefer first empty slot | ✓ VERIFIED | `:331-332`, `:138-145` |
|
||||
| `packages-user/data-base/src/hero/attribute.ts` | No-modifier `final` reflects `base` | ✓ VERIFIED | `:82-85` |
|
||||
| `packages-user/data-base/src/map/mapLayer.ts` | Out-of-map `transferToDynamic` emits 128 | ✓ VERIFIED | `:441` |
|
||||
| `packages-user/data-base/src/map/dynamicTile.ts` | `loadState` restores `num` | ✓ VERIFIED | `:122-123` |
|
||||
| `packages-user/data-common/src/common/mover.ts` | `backward` basis fixed across multi-step | ✓ VERIFIED | `:501-505` |
|
||||
| `packages-user/data-state/src/core.ts` | Code 178 = keys saved but not loaded; finder wiring | ✓ VERIFIED | `:540`; `:232-241` |
|
||||
| `packages-user/data-base/src/map/dynamicTile.ts` | `loadState` restores `num` | ✓ VERIFIED | `:122` (`set(save.num)` before events) |
|
||||
| `packages-user/data-common/src/common/mover.ts` | `backward` basis fixed across multi-step | ✓ VERIFIED | `:501-505`; jsdoc `:309-313` |
|
||||
| `packages-user/data-state/src/core.ts` | Code 178 = keys saved but not loaded; finder wiring | ✓ VERIFIED | `:540`; `:236-241` |
|
||||
| `packages-user/data-state/test/replayPlayback.test.ts` | Top-level teleport regression witness | ✓ VERIFIED | `:363` renamed case, active, green |
|
||||
|
||||
All planned production artifacts exist, are substantive (no stubs / placeholders / empty returns — the `return null` matches are all guard clauses), and are wired to a real data source.
|
||||
@ -193,20 +198,20 @@ All planned production artifacts exist, are substantive (no stubs / placeholders
|
||||
| From | To | Via | Status | Details |
|
||||
| --- | --- | --- | --- | --- |
|
||||
| `combat.ts:179` return-value test | `combat/types.ts:772` jsdoc (D-03 contract source) | `!proceed` semantics | ✓ WIRED | jsdoc unchanged; implementation now matches 返回 `false`…放弃战斗 |
|
||||
| `context.ts buildup()` | `combat/enemy.ts` `EnemyView.reset()` | reuse of existing reset API | ✓ WIRED | `context.ts:698` |
|
||||
| `context.ts buildup()` | `combat/enemy.ts` `EnemyView.reset()` | reuse of existing reset API | ✓ WIRED | `context.ts:697-698` |
|
||||
| `mapDamage.ts` write path | `deleteEnemy`/`removeEnemyAffecting`/`refreshIndex` | `registerSourcedDamage` → `viewStore`/`damageStore` | ✓ WIRED | reader + deleter keyed by the same `viewItem`/`index`; `mapDamage.test.ts:532` green |
|
||||
| `damage.ts findNextCritical` | `calculateCritical` info consumer | `targetInfo` tracks `value: right` | ✓ WIRED | verified by un-skipped `damage.test.ts` assertion |
|
||||
| `array.ts` decode multiplier | `array.ts` encode high/low split | `2147483648` both sides | ✓ WIRED | `:647` ↔ `:380-381` |
|
||||
| negative int64 type 5 | `setParamArray` magnitude write ↔ `decodeParam` negation | type code 5 | ✓ WIRED | `:377-383` ↔ `:653` |
|
||||
| negative bigint type 8 | length prefix + magnitude bytes ↔ `getUint8` read + negation | type code 8 | ✓ WIRED | `:269-285` ↔ `:660-666` |
|
||||
| `damage.ts findNextCritical` | `calculateCritical` info consumer | `targetInfo` tracks `value: right` | ✓ WIRED | verified by active `damage.test.ts:579` assertion |
|
||||
| `array.ts` decode multiplier | `array.ts` encode high/low split | `2147483648` both sides | ✓ WIRED | `:647` ↔ `:378-381` |
|
||||
| negative int64 type 5 | `setParamArray` magnitude write ↔ `decodeParam` negation | type code 5 | ✓ WIRED | `:376-381` ↔ `:653` |
|
||||
| negative bigint type 8 | length prefix + magnitude bytes ↔ `getUint8` read + negation | type code 8 | ✓ WIRED | `:269-284` ↔ `:660-666` |
|
||||
| short string `type = length + 9` | encode ↔ decode `length = type - 9` | type codes 10–255 | ✓ WIRED | `:288-294` ↔ `:677` |
|
||||
| `equipStore.ts loadDiff` | `saveDiff` with `this.item.equip` as base | diff semantics | ✓ WIRED | `:137-150` |
|
||||
| `equipment.ts saveState` deep copy | `ISaveableContent` contract | independent snapshot | ✓ WIRED | verified by un-skipped `saveLoad.test.ts` |
|
||||
| `dynamicTile.ts loadState` | same-file `set` + `saveState` (`num`) | `set(save.num)` | ✓ WIRED | `:122-123` |
|
||||
| `equipStore.ts loadDiff` | `saveDiff` with `this.item.equip` as base | diff semantics | ✓ WIRED | `:136-152` |
|
||||
| `equipment.ts saveState` deep copy | `ISaveableContent` contract | independent snapshot | ✓ WIRED | verified by `saveLoad.test.ts:312` (active) |
|
||||
| `dynamicTile.ts loadState` | same-file `set` + `saveState` (`num`) | `set(save.num)` | ✓ WIRED | `:122` |
|
||||
| `core.ts` finder injection | `path/finder.ts` `useMapState`/`useMapLayer`/`usePassPredicate` | `:236-241` | ✓ WIRED | teleport test green after test-side layer binding |
|
||||
| `mapLayer.ts` code 128 | `logger.json` warn-128 text | D-04 | ✓ WIRED | "target position $3,$4 out of bounds" |
|
||||
| `mapLayer.ts` code 128 | `logger.json` warn-128 text | D-04 | ✓ WIRED | "target position $3,$4 out of bounds"; `logger.json` unchanged |
|
||||
| `core.ts:540` code 178 | `logger.json` warn-178 text | D-05 | ✓ WIRED | `loaded.difference(total)` = saved-but-not-loaded |
|
||||
| `replay/types.ts` param table | `array.ts` type table `:11-26` | align 0224c2e | ✓ WIRED | both tables now describe 4/5 int64, 6 float, 7/8 bigint, 9 long string, 10–255 short string |
|
||||
| `replay/types.ts` param table | `array.ts` type table `:11-25` | align 0224c2e | ✓ WIRED | both tables describe 4/5 int64, 6 float, 7/8 bigint, 9 long string, 10–255 short string |
|
||||
|
||||
No `NOT_WIRED` or `PARTIAL` key links.
|
||||
|
||||
@ -229,13 +234,16 @@ No `STATIC`, `HOLLOW`, `HOLLOW_PROP` or `DISCONNECTED` data paths found.
|
||||
| --- | --- | --- | --- |
|
||||
| Full data suite green, no new skips | `pnpm test:ci` | `Test Files 66 passed (66)`, `Tests 680 passed | 1 skipped (681)` | ✓ PASS |
|
||||
| Lint gate on changed files | `pnpm exec eslint <28 changed data-side files>` | no output, `exit=0` | ✓ PASS |
|
||||
| Type gate in data range | `pnpm exec vue-tsc --noEmit` | 27 error lines, **0** matching any changed phase-7 file | ✓ PASS |
|
||||
| Type gate in data range | `pnpm exec vue-tsc --noEmit` | 27 error lines; distinct error files = `legacy-ui/equipbox.tsx`, `client-modules/*`, `legacy-plugin-data/fallback.ts` — **0** phase-7 changed files | ✓ PASS |
|
||||
| Circular gate in data range | `pnpm check:circular` | 4 cycles, all `packages/render/*` / `packages/anon-tokyo/*`; none in `packages-user/data-*` | ✓ PASS |
|
||||
| Renderer/legacy untouched | `git diff --name-only 817201c..HEAD \| Select-String "client\|legacy\|render"` | empty | ✓ PASS |
|
||||
| No new skip introduced | repo-wide disabled-test census | exactly **1** (`equipment.test.ts:306`, D-06 retained) | ✓ PASS |
|
||||
| No new skip introduced | repo-wide disabled-test census (`it.skip`/`describe.skip`/`test.skip`/`xit`/`xdescribe`) | exactly **1** (`equipment.test.ts:306`, D-06 retained) | ✓ PASS |
|
||||
| Debt markers in changed impl files | `Select-String "TBD\|FIXME\|XXX"` on every changed non-test `.ts` (14 files) | none | ✓ PASS |
|
||||
| Retained skip comment present | `equipment.test.ts:305` | 保留错误码 147…设计如此…生产代码不修改 | ✓ PASS |
|
||||
| Fingerprint fresh | `query verification.fingerprint <phaseDir> <50 files>` | `v1:sha256:3bf6ed09…` (matches frontmatter) | ✓ PASS |
|
||||
| 19 target cases active (not skipped) | named `it(` titles across the 19 registered findings | all present as active `it(`, none `it.skip` | ✓ PASS |
|
||||
| `#06-05-3` production untouched | `git diff 817201c..HEAD -- hero/equipment.ts \| Select-String 147`; `logger.json` changed? | empty; empty | ✓ PASS |
|
||||
| Requirement/roadmap tracking current | `REQUIREMENTS.md:41/70`, `ROADMAP.md:312/327` | `[x] FIX-01`, `Complete`; `[x]`; `8/8 Complete 2026-09-16` | ✓ PASS |
|
||||
| Fingerprint fresh | `query verification.fingerprint <phaseDir> <52 files>` | `v1:sha256:2bb44f7d…` (matches frontmatter) | ✓ PASS |
|
||||
|
||||
### Probe Execution
|
||||
|
||||
@ -286,21 +294,21 @@ No debt markers (`TBD`/`FIXME`/`XXX`) in any file changed by this phase → debt
|
||||
|
||||
None. Every must-have truth resolves to a passing, active automated test or to programmatically verifiable source state.
|
||||
|
||||
**Infrastructure/foundation phase scoping:** this is a headless data-layer phase (D-12) — no UI, CLI output, or real-time behaviour is claimed. Per the infrastructure-phase gate, UAT auto-passes; `human_verification: []`.
|
||||
**Infrastructure/foundation phase scoping:** this is a headless data-layer phase (D-12) — no UI, CLI output, or real-time behaviour is claimed. Per the infrastructure-phase gate, UAT auto-passes (`07-UAT.md`: 6 passed / 0 issues); `human_verification: []`.
|
||||
|
||||
Items deliberately **not** raised as human-verification items, with rationale:
|
||||
|
||||
- **`#06-05-3` code 147 retained** — user adjudication recorded in `07-CONTEXT.md` D-06; verified statically (skip + comment present, production unchanged).
|
||||
- **`#06-05-3` code 147 retained** — user adjudication recorded in `07-CONTEXT.md` D-06; verified statically (skip + comment present, production unchanged, `logger.json` unchanged).
|
||||
- **Residual path gaps** — user adjudication recorded in `07-08-SUMMARY.md` D2/D3 (`只登记不修`, `human_judgment: true`). Registered outcomes, not unverified claims.
|
||||
- **`07-REVIEW.md` findings** — classified advisory above; none is a must-have failure and none has deterministic (failing-test) evidence.
|
||||
|
||||
## Gaps Summary
|
||||
|
||||
**No phase-goal gap.** All 20 registered data-side defects are disposed of as the user adjudicated; all 19 un-skippable correct-expectation cases are active and green; `pnpm test:ci` is 680 passed / 1 skipped (the single remaining skip is the D-06-by-design one); lint/type/circular gates are clean in the data range; the renderer/legacy boundary is untouched; the post-verification doc fix and review-report artifacts are reconciled.
|
||||
**No phase-goal gap.** All 20 registered data-side defects are disposed of as the user adjudicated; all 19 un-skippable correct-expectation cases are active and green; `pnpm test:ci` is 680 passed / 1 skipped (the single remaining skip is the D-06-by-design one); lint/type/circular gates are clean in the data range; the renderer/legacy boundary is untouched; and the three phase artifacts added after the prior verification (`07-UAT.md`, `07-SECURITY.md`, `07-VALIDATION.md`) are reconciled into this run's covered set.
|
||||
|
||||
No must-have truth, artifact, or key link failed. The four previously-recorded informational observations (W-01, I-02, I-03, I-04) are all resolved by post-verification commits. The only remaining items are the 9 advisory review findings, none of which contradicts a must-have and none of which carries deterministic evidence — they are recorded in the `advisory:` frontmatter for a future decision, not as phase blockers.
|
||||
No must-have truth, artifact, or key link failed. The four previously-recorded informational observations (W-01, I-02, I-03, I-04) remain resolved. The only remaining items are the 9 advisory review findings, none of which contradicts a must-have and none of which carries deterministic evidence — they are recorded in the `advisory:` frontmatter for a future decision, not as phase blockers.
|
||||
|
||||
---
|
||||
|
||||
_Verified: 2026-09-16T05:49:24Z_
|
||||
_Verified: 2026-09-16T06:04:11Z_
|
||||
_Verifier: the agent (gsd-verifier)_
|
||||
|
||||
Loading…
Reference in New Issue
Block a user