AncTe/template
1
0
Fork 0
mirror of https://github.com/motajs/template.git synced 2026-10-02 08:30:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(07-03): #06-04-4 shift replay params in the insert direction

Browse Source 
- Move paramArray bytes to paramStart + length so later steps keep their data
- Move indexArray entries to index + 1 so get(i) sees the inserted step
- Un-skip both insert order cases
This commit is contained in:
unanmed 2026-09-15 18:50:30 +08:00
parent 45dde1cb1c
commit 40824cc10b
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages-user/data-common/src/replay/array.test.ts
View File

@ -554,8 +554,8 @@ describe('ReplayArray stream and buffer combination', () => {
expectHeterogeneousRead(array, heterogeneousSteps.slice(1));
});
// 疑似 bug：insert 的参数缓冲区位移方向相反，已有参数时后续步骤读到错误参数，详见 06-TEST-FINDINGS.md #06-04-4，修复后取消 skip
it.skip('reads the new order after inserting a step', () => {
// 验证 insert 后参数缓冲区后移，读流按新次序精确读回
it('reads the new order after inserting a step', () => {
const array = createArray();
array.add(1, [10]);
array.add(3, [30]);
@ -579,8 +579,8 @@ describe('ReplayArray stream and buffer combination', () => {
expectRouteStream(array, remaining);
});
// 疑似 bug：insert 的参数缓冲区位移方向相反，异质序列新次序读流会读到错误参数，详见 06-TEST-FINDINGS.md #06-04-4，修复后取消 skip
it.skip('reads the new order after inserting a step into a heterogeneous route', () => {
// 验证 insert 的参数与索引位移方向一致，异质序列插入后按新次序精确读回
it('reads the new order after inserting a step into a heterogeneous route', () => {
const array = createHeterogeneousArray();
array.insert(2, 9, [true, 5]);

4
packages-user/data-common/src/replay/array.ts
View File

@ -446,8 +446,8 @@ export class ReplayArray implements IReplayArray {
const commandStart = index * commandSize;
const paramStart = this.indexArray[index];
this.commandArray.copyWithin(commandStart + commandSize, commandStart);
this.paramArray.copyWithin(paramStart, paramStart + length);
this.indexArray.copyWithin(index, index + 1);
this.paramArray.copyWithin(paramStart + length, paramStart);
this.indexArray.copyWithin(index + 1, index);
// 然后进行赋值操作，索引数组因为这一个指令的起始索引其实没变，所以不需要赋值
this.setCommandArray(commandStart, params.length, command);